feat: Additional options for saveArtwork#9
Merged
Conversation
- Base `ImageFormat` class on `expo-image-manipulator` code - https://github.com/expo/expo/blob/sdk-53/packages/expo-image-manipulator/android/src/main/java/expo/modules/imagemanipulator/ImageManipulatorArguments.kt#L58-L80
- Export a `SaveFormat` constant & type. - New internal `ObjectValues` type.
- Made description for `compress` option more clearer.
- Changed `compress` to `0.8` from `true`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies and adds some options to
saveArtworkwhich improves the "compression" feature.formatoption which allows us to specify the format of the saved file (defaults tojpeg).compressoption to expect a number between0.0&1.0which represents the quality of the saved image (defaults to1).This change is inspired by the
saveAsyncfunction fromexpo-image-manipulator.ImageFormatenum class was based off of this fromexpo-image-manipulator.